Repository navigation
rmake: Add helpers for iterating symbols and objects - #163087
Merged
Merged
Conversation
rustbot
added
A-run-make
This comment has been minimized.
This comment has been minimized.
tgross35
force-pushed
the
rmake-syms
branch
from
September 21, 2026 05:21
2c984b3 to
bfe5811
Compare
This comment has been minimized.
This comment has been minimized.
tgross35
force-pushed
the
rmake-syms
branch
from
September 21, 2026 05:40
bfe5811 to
ea4f458
Compare
This comment has been minimized.
This comment has been minimized.
tgross35
force-pushed
the
rmake-syms
branch
from
September 21, 2026 06:46
ea4f458 to
7d3f92e
Compare
This comment has been minimized.
This comment has been minimized.
tgross35
force-pushed
the
rmake-syms
branch
from
September 21, 2026 06:55
7d3f92e to
dd11c3e
Compare
This comment has been minimized.
This comment has been minimized.
tgross35
force-pushed
the
rmake-syms
branch
from
September 21, 2026 08:00
dd11c3e to
0047e2a
Compare
tgross35
marked this pull request as ready for review
October 19, 2026 07:53
Collaborator
|
The run-make-support library was changed cc @jieyouxu |
rustbot
added
S-waiting-on-review
Collaborator
|
r? @jieyouxu rustbot has assigned @jieyouxu. Use Why was this reviewer chosen?The reviewer was selected based on:
|
jieyouxu
approved these changes
Oct 22, 2026
rustbot
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
This module can contain various helpers for `object`, not strictly those that work with symbols.
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Member
Author
|
@bors r=jieyouxu |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Oct 22, 2026
rmake: Add helpers for iterating symbols and objects We have a handful tests that do a common pattern of opening a file, looping through its symbols, and performing some validation on each one, which can be a bit inconvenient to do manually. The pattern at https://github.com/rust-lang/compiler-builtins/blob/f521807de24520770991263387ba8c06e462edf8/crates/symcheck/src/main.rs works rather well to make this easier, so add it at `rmake` and update one test that does symbol iteration.
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 22, 2026
…uwer Rollup of 5 pull requests Successful merges: - #161790 (update to illumos sysroot 20210501) - #163087 (rmake: Add helpers for iterating symbols and objects) - #163983 (std: use `SOCK_NONBLOCK` in `connect_timeout`) - #164636 (Remove `record_*` macros from the metadata encoder) - #164717 (Allow `llm-assisted` label to be set without write access)
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 22, 2026
…uwer Rollup of 12 pull requests Successful merges: - #164458 (Avoid stdlib's `impl Hash for Path` for stable hashing) - #161790 (update to illumos sysroot 20210501) - #163087 (rmake: Add helpers for iterating symbols and objects) - #163586 (refactor Windows remove_dir_all) - #163983 (std: use `SOCK_NONBLOCK` in `connect_timeout`) - #164307 (Rename `PostTypeckUntilBorrowck` -> `PostTypeckThroughBorrowck`) - #164425 (Declare `SyntaxContext` through `rustc_index::newtype_index!`) - #156841 (Avoid cloning CFG-related analysis data.) - #164654 (Add reference annotations for unions) - #164717 (Allow `llm-assisted` label to be set without write access) - #164735 (Remove docs mentioning instability of wasm64) - #164737 (Update LLVM PassBuilder constructor calls to pass a context) Failed merges: - #164636 (Remove `record_*` macros from the metadata encoder)
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 23, 2026
…uwer Rollup of 12 pull requests Successful merges: - #164458 (Avoid stdlib's `impl Hash for Path` for stable hashing) - #161790 (update to illumos sysroot 20210501) - #163087 (rmake: Add helpers for iterating symbols and objects) - #163586 (refactor Windows remove_dir_all) - #163983 (std: use `SOCK_NONBLOCK` in `connect_timeout`) - #164307 (Rename `PostTypeckUntilBorrowck` -> `PostTypeckThroughBorrowck`) - #164425 (Declare `SyntaxContext` through `rustc_index::newtype_index!`) - #156841 (Avoid cloning CFG-related analysis data.) - #164654 (Add reference annotations for unions) - #164717 (Allow `llm-assisted` label to be set without write access) - #164735 (Remove docs mentioning instability of wasm64) - #164737 (Update LLVM PassBuilder constructor calls to pass a context) Failed merges: - #164636 (Remove `record_*` macros from the metadata encoder)
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 23, 2026
…uwer Rollup of 12 pull requests Successful merges: - #164458 (Avoid stdlib's `impl Hash for Path` for stable hashing) - #161790 (update to illumos sysroot 20210501) - #163087 (rmake: Add helpers for iterating symbols and objects) - #163586 (refactor Windows remove_dir_all) - #163983 (std: use `SOCK_NONBLOCK` in `connect_timeout`) - #164307 (Rename `PostTypeckUntilBorrowck` -> `PostTypeckThroughBorrowck`) - #164425 (Declare `SyntaxContext` through `rustc_index::newtype_index!`) - #156841 (Avoid cloning CFG-related analysis data.) - #164654 (Add reference annotations for unions) - #164717 (Allow `llm-assisted` label to be set without write access) - #164735 (Remove docs mentioning instability of wasm64) - #164737 (Update LLVM PassBuilder constructor calls to pass a context) Failed merges: - #164636 (Remove `record_*` macros from the metadata encoder)
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 23, 2026
Rollup merge of #163087 - tgross35:rmake-syms, r=jieyouxu rmake: Add helpers for iterating symbols and objects We have a handful tests that do a common pattern of opening a file, looping through its symbols, and performing some validation on each one, which can be a bit inconvenient to do manually. The pattern at https://github.com/rust-lang/compiler-builtins/blob/f521807de24520770991263387ba8c06e462edf8/crates/symcheck/src/main.rs works rather well to make this easier, so add it at `rmake` and update one test that does symbol iteration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a handful tests that do a common pattern of opening a file, looping through its symbols, and performing some validation on each one, which can be a bit inconvenient to do manually. The pattern at https://github.com/rust-lang/compiler-builtins/blob/f521807de24520770991263387ba8c06e462edf8/crates/symcheck/src/main.rs works rather well to make this easier, so add it at
rmakeand update one test that does symbol iteration.